linux-kernel - Re: [PATCH] Revert "[media] au0828: use v4l2_mc_create_media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160310145309.30c47210@recife.lan>
Date:	Thu, 10 Mar 2016 14:53:09 -0300
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	hans.verkuil@...co.com, nenggun.kim@...sung.com,
	inki.dae@...sung.com, jh1009.sung@...sung.com,
	chehabrafael@...il.com, sakari.ailus@...ux.intel.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "[media] au0828: use
 v4l2_mc_create_media_graph()"

Em Thu, 10 Mar 2016 09:16:30 -0700
Shuah Khan <shuahkh@....samsung.com> escreveu:

> On 03/08/2016 08:26 PM, Shuah Khan wrote:
> > This reverts commit 9822f4173f84cb7c592edb5e1478b7903f69d018.
> > This commit breaks au0828_enable_handler() logic to find the tuner.
> > Audio, Video, and Digital applications are broken and fail to start
> > streaming with tuner busy error even when tuner is free.
> > 
> > Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> > ---
> >  drivers/media/usb/au0828/au0828-video.c | 103 ++++++++++++++++++++++++++++++--
> >  drivers/media/v4l2-core/v4l2-mc.c       |  21 +------
> >  2 files changed, 99 insertions(+), 25 deletions(-)
> >   
> 
> Hi Mauro,
> 
> Please pull this revert in as soon as possible. Without
> the revert, auido, video, and digital applications won't
> start even. There is a bug in the common routine introduced
> in the commit 9822f4173f84cb7c592edb5e1478b7903f69d018 which
> causes the link between source and sink to be not found.
> I am testing on WIn-TV HVR 950Q

No, this patch didn't seem to have broken anything. The problems
you're reporting seem to be related, instead, to this patch:

	https://patchwork.linuxtv.org/patch/33422/

I rebased it on the top of the master tree (without reverting this
patch).

Please check if it solved for you.

Yet, I'm seeing several troubles with au0828 after your patch series:

1) when both snd-usb-audio and au0828 are compiled as module and not
blacklisted, I'm getting some errors:
	http://pastebin.com/nMzr3ueM

2) removing/reprobing au0828 driver ~3 times, the Kernel becomes
unstable. Probably, some kobj ref were decremented every time a
module insert/removal pair is called from userspace, causing the
kref to reach zero, thus causing the trouble;

3) the media entities that should have been created by
media_snd_stream_init() are never created. Maybe this is related
with (1).

Please check.

Regards,
Mauro