linux-kernel - Re: [PATCH] ld-version: Fix awk regex compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160310205004.GB31414@jhogan-linux.le.imgtec.org>
Date:	Thu, 10 Mar 2016 20:50:04 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	Ralf Baechle <ralf@...ux-mips.org>, Michal Marek <mmarek@...e.com>,
	"Andi Kleen" <ak@...ux.intel.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"Michael S. Tsirkin" <mst@...hat.com>, <linux-mips@...ux-mips.org>,
	<linux-kbuild@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] ld-version: Fix awk regex compile failure

On Thu, Mar 10, 2016 at 11:19:57PM +0530, Sudip Mukherjee wrote:
> On Tuesday 08 March 2016 10:17 PM, James Hogan wrote:
> > The ld-version.sh script fails on some versions of awk with the
> > following error, resulting in build failures for MIPS:
> >
> > awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(')
> >
> > This is due to the regular expression ".*)", meant to strip off the
> > beginning of the ld version string up to the close bracket, however
> > brackets have a meaning in regular expressions, so lets escape it so
> > that awk doesn't expect a corresponding open bracket.
> >
> > Fixes: ccbef1674a15 ("Kbuild, lto: add ld-version and ld-ifversion ...")
> > Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Signed-off-by: James Hogan <james.hogan@...tec.com>
> 
> This error was only coming in my gitlab builds but was not showing in 
> the build of travis-ci. Maybe it depends on the version of awk also.
> Build log at: https://gitlab.com/sudipm/linux-next/builds/839573
> 
> Tested-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Great, that looks pretty conclusive. Thanks for testing Sudip and
Michael.

Ralf: is it too late to get this into v4.5 via MIPS tree?

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)