linux-kernel - Re: [PATCH v8 00/17] add fixes, device quirks, error recovery,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E28703.4090702@suse.de>
Date:	Fri, 11 Mar 2016 09:51:15 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	James.Bottomley@...senPartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v8 00/17] add fixes, device quirks, error recovery,

On 03/11/2016 03:36 AM, Martin K. Petersen wrote:
>>>>>> "Yaniv" == Yaniv Gardi <ygardi@...eaurora.org> writes:
> 
> Yaniv> V8: fixed cyclic dependency by removing ufs_quirk.c that was
> Yaniv> previously added in V7 06/17, and moving its code into ufshcd.c
> 
> Patch 6 is now different yet it retains Reviewed-by: tags from the
> previous version. These should have been removed.
> 
> But if Hannes is OK with the changed version you don't need to
> resend. Hannes, if you would be so kind to take a second look?
> 
As indicated, I'm still not happy with the timeout handler, it
really should be sending real command aborts and not just extending
the timeout.
But it's better then nothing, and having this patchset in leaves us
with more time to discuss other matters.
EG ioctl interfaces ;-)

So:

Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)