linux-kernel - Re: [patch] kexec: potetially using uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160311091919.GD5273@mwanda>
Date:	Fri, 11 Mar 2016 12:19:19 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	xlpang@...hat.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vivek Goyal <vgoyal@...hat.com>,
	Dave Young <dyoung@...hat.com>, Ingo Molnar <mingo@...nel.org>,
	Toshi Kani <toshi.kani@....com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Minfei Huang <mnfhuang@...il.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] kexec: potetially using uninitialized variable

On Fri, Mar 11, 2016 at 04:52:43PM +0800, Xunlei Pang wrote:
> Hi Dan,
> 
> On 2016/03/11 at 16:07, Dan Carpenter wrote:
> > At the end of the function we check if "ret" has a negative error code,
> > but it seems possible that it is uninitialized.
> >
> > Fixes: 12db5562e035 ('kexec: load and relocate purgatory at kernel load time')
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> >
> > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> > index 503bc2d..63d1af3 100644
> > --- a/kernel/kexec_file.c
> > +++ b/kernel/kexec_file.c
> > @@ -795,7 +795,7 @@ out:
> >  
> >  static int kexec_apply_relocations(struct kimage *image)
> >  {
> > -	int i, ret;
> > +	int i, ret = 0;
> >  	struct purgatory_info *pi = &image->purgatory_info;
> >  	Elf_Shdr *sechdrs = pi->sechdrs;
> >  
> 
> Look further, there is a condition at the beginning of the for loop:
>  
> 
>         if (sechdrs[i].sh_type != SHT_RELA &&
>             sechdrs[i].sh_type != SHT_REL)
>             continue;
> 
> So, I think that's ok, but I don't konw if GCC is smart enough not to throw warnings.

Ah, right...

This wasn't a GCC warning.  GCC misses a lot of uninitialized variable
bugs so I'm doing this with Smatch.

Anyway, I'll patch this up in Smatch to not warn about this.

regards,
dan carpenter