linux-kernel - Re: [PATCH] net: mvneta: Add missing hotplug notifier transition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1603111146310.3657@nanos>
Date:	Fri, 11 Mar 2016 11:48:40 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
cc:	Anna-Maria Gleixner <anna-maria@...utronix.de>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	rt@...utronix.de
Subject: Re: [PATCH] net: mvneta: Add missing hotplug notifier transition

Gregory,

On Fri, 11 Mar 2016, Gregory CLEMENT wrote:
>  On ven., mars 11 2016, Anna-Maria Gleixner <anna-maria@...utronix.de> wrote:
> 
> > The mvneta_percpu_notifier() hotplug callback lacks handling of the
> > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the
> > driver is not well configured on the CPU.
> >
> > Add handling for CPU_DOWN_FAILED[_FROZEN] hotplug notifier transition
> > to setup the driver.
> 
> I agree that we need to handle this case, however reusing CPU_ONLINE
> case for it seems too much.

Why is that too much? If it does the job, then it's definitely preferrable
over an extra case for a non hotpath error handling operation.

Thanks,

	tglx