linux-kernel - Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2016 11:39:08 -0300
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	Javier Martinez Canillas <javier@....samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Kukjin Kim <kgene@...nel.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT
 port/endpoint parse logic

Hello Sylwester,

On Fri, Mar 11, 2016 at 10:09 AM, Sylwester Nawrocki
<s.nawrocki@...sung.com> wrote:
> On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote:
>> Thanks, I just noticed another similar issue in the driver now and is
>> that fimc_is_parse_sensor_config() uses the same struct device_node *
>> for looking up the I2C sensor, port and endpoint and thus not doing a
>> of_node_put() for all the nodes on the error path.
>>
>> I think the right fix is to have a separate struct device_node * for
>> each so their reference counter can be incremented and decremented.
>
> Yes, the node reference count is indeed not handled very well there,
> feel free to submit a patch to fix that bug.
>

Ok, I'll post a patch to fix that once all the in-flight patches land
to avoid merge conflicts.

> --
> Regards,
> Sylwester

Best regards,
Javier