linux-kernel - Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E2D8D1.7040306@linux.vnet.ibm.com>
Date:	Fri, 11 Mar 2016 08:40:17 -0600
From:	Manoj Kumar <manoj@...ux.vnet.ibm.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Hannes Reinecke <hare@...e.de>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	Ewan Milne <emilne@...hat.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] scsi_dh_alua: uninitialized variable in
 alua_check_vpd()

On 3/11/2016 5:19 AM, Dan Carpenter wrote:
> The pg_updated variable is support to be set to false at the start but
> it is uninitialized.
>
> Fixes: cb0a168cb6b8 ('scsi_dh_alua: update 'access_state' field')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 5bcdf8d..a404a41 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -332,7 +332,7 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
>   {
>   	int rel_port = -1, group_id;
>   	struct alua_port_group *pg, *old_pg = NULL;
> -	bool pg_updated;
> +	bool pg_updated = false;
>   	unsigned long flags;

Reviewed-by: Manoj Kumar <manoj@...ux.vnet.ibm.com>

---
Manoj Kumar