linux-kernel - Re: [PATCH] ARM: OMAP2: Fix up interconnect barrier initialization for DRA7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4167118.MBvk7Vsb05@avalon>
Date:	Fri, 11 Mar 2016 18:46:07 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Nishanth Menon <nm@...com>
Cc:	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH] ARM: OMAP2: Fix up interconnect barrier initialization for DRA7

Hi Nishanth,

Thank you for the patch.

On Friday 11 March 2016 10:12:28 Nishanth Menon wrote:
> The following commits:
> commit 3fa609755c11 ("ARM: omap2: restore OMAP4 barrier behaviour")
> commit f746929ffdc8 ("Revert "ARM: OMAP4: remove dead kconfig option
> OMAP4_ERRATA_I688"") and
> commit ea827ad5ffbb ("ARM: DRA7: Provide proper IO map table")
> came in around the same time, unfortunately this seem to have missed
> initializing the barrier for DRA7 platforms - omap5_map_io was reused
> for dra7 till it was split out by the last patch. barrier_init
> needs to be hence carried forward as it is valid for DRA7 family of
> processors as they are for OMAP5.
> 
> Fixes: ea827ad5ffbb7 ("ARM: DRA7: Provide proper IO map table")
> Reported-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Nishanth Menon <nm@...com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> 
> Original thread of report:
> http://www.spinics.net/lists/dri-devel/msg101246.html
> 
>  arch/arm/mach-omap2/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 3c87e40650cf..9821be6dfd5e 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -368,6 +368,7 @@ void __init omap5_map_io(void)
>  void __init dra7xx_map_io(void)
>  {
>  	iotable_init(dra7xx_io_desc, ARRAY_SIZE(dra7xx_io_desc));
> +	omap_barriers_init();
>  }
>  #endif
>  /*

-- 
Regards,

Laurent Pinchart