linux-kernel - Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2016 10:05:21 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Andrew Duggan <aduggan@...aptics.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux Input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiri Kosina <jikos@...nel.org>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>,
	Chris Healy <cphealy@...il.com>,
	Andrey Gusakov <andrey.gusakov@...entembedded.com>,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver

On Thu, Mar 03, 2016 at 06:11:38PM +0100, Benjamin Tissoires wrote:
> On Feb 12 2016 or thereabouts, Andrew Duggan wrote:
> > On 02/12/2016 04:54 AM, Linus Walleij wrote:
> > >On Wed, Feb 10, 2016 at 11:23 PM, Andrew Duggan <aduggan@...aptics.com> wrote:
> > >
> > >>This is the v5 patch series which fixes the issues identified by kbuild
> > >>and coccinelle in the previous patch series. These include:
> > >>
> > >>- Using ARRAY_SIZE instead of a custom macro to calculate the size of the
> > >>   function handler array.
> > >>- Remove setting the .owner field for the driver in rmi_i2c and rmi_spi
> > >>   since the i2c-core and spi set that field.
> > >>- Fix if statment in rmi_f30 which was testing has_led twice instead of
> > >>   testing has_gpio.
> > >Works like a charm.
> > >Tested-by: Linus Walleij <linus.walleij@...aro.org>
> > 
> > Thanks for testing. At this point except for the touchscreen binding rename
> > fix needed in patch 5, all of the outstanding issues have been addressed. If
> > the rest of the patch series is acceptable, then I can do a final v6 respin
> > which fixes the binding and also removes the HID patch. But, if more work
> > needs to be done on the patch series I can wait to do the respin. Dmitry,
> > what do you think of the patch series at this point?
> 
> Dmitry, ping on this one...
> 
> I'd like to see the series in 4.6, and we are getting closer of the
> merge window. Could we get some of your time on this?

I adjusted the binding on patch 5 (to read -x-mm and y-mm) and applied
the first 9 leaving the HID out for now.

Thanks.

-- 
Dmitry