linux-kernel - Re: [PATCH] staging: rtl8712: added few code enhancements in rtl8712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56E30C32.6070102@lwfinger.net>
Date:	Fri, 11 Mar 2016 12:19:30 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Claudiu Beznea <claudiu.beznea@...il.com>,
	florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
	luisbg@....samsung.com, sudipm.mukherjee@...il.com,
	vthakkar1994@...il.com
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: added few code enhancements in
 rtl8712_led.c

On 03/09/2016 03:54 PM, Claudiu Beznea wrote:
> This patch tries to improve a part of the code from
> rtl8712_led.c by removing duplicates condition checks.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...il.com>
> ---
>   drivers/staging/rtl8712/rtl8712_led.c | 31 +++++++++++++++----------------
>   1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging/rtl8712/rtl8712_led.c
> index 9055827..aea6f2d 100644
> --- a/drivers/staging/rtl8712/rtl8712_led.c
> +++ b/drivers/staging/rtl8712/rtl8712_led.c
> @@ -221,11 +221,9 @@ static void SwLedBlink(struct LED_871x *pLed)
>   		break;
>   	case LED_BLINK_StartToBlink:
>   		if (check_fwstate(pmlmepriv, _FW_LINKED) &&
> -		    (pmlmepriv->fw_state & WIFI_STATION_STATE))
> -			bStopBlinking = true;
> -		if (check_fwstate(pmlmepriv, _FW_LINKED) &&
> -		    ((pmlmepriv->fw_state & WIFI_ADHOC_STATE) ||
> -		    (pmlmepriv->fw_state & WIFI_ADHOC_MASTER_STATE)))
> +			((pmlmepriv->fw_state & WIFI_STATION_STATE) ||
> +			 (pmlmepriv->fw_state & WIFI_ADHOC_STATE)	||
> +			 (pmlmepriv->fw_state & WIFI_ADHOC_MASTER_STATE)))

The above hunk messes up the alignment of the if statement. Observe the 
alignment of the stuff you are removing. It is correct.


Other than the alignment above, the rest of the patch is correct.

Larry