linux-kernel - Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <56E22FF3.7070003@samsung.com>
Date:	Fri, 11 Mar 2016 08:09:47 +0530
From:	"pankaj.dubey" <pankaj.dubey@...sung.com>
To:	Rob Herring <robh@...nel.org>
Cc:	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, k.kozlowski@...sung.com,
	thomas.ab@...sung.com, olof@...om.net, p.fedin@...sung.com,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	devicetree@...r.kernel.org, Kukjin Kim <kgene@...nel.org>
Subject: Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree
 binding



On Saturday 05 March 2016 11:48 AM, pankaj.dubey wrote:
> Hi
> 
> On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote:
>> On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote:
>>> This patch adds exynos-srom binding information for SROM Controller
>>> driver on Exynos SoCs.
>>>
>>> CC: Rob Herring <robh+dt@...nel.org>
>>> CC: Mark Rutland <mark.rutland@....com>
>>> CC: Ian Campbell <ijc+devicetree@...lion.org.uk>
>>> CC: devicetree@...r.kernel.org
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>>> Signed-off-by: Kukjin Kim <kgene@...nel.org>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>>> ---
>>>  .../devicetree/bindings/memory-controllers/exynos-srom.txt   | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> new file mode 100644
>>> index 0000000..33886d5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> @@ -0,0 +1,12 @@
>>> +SAMSUNG Exynos SoCs SROM Controller driver.
>>> +
>>> +Required properties:
>>> +- compatible : Should contain "samsung,exynos-srom".
>>
>> There should be SoC specific compatible strings in addition to this.
>>
> 
> I do not understood need of additional SoC specific compatible here. As
> of now all SoCs having SROM can work with exynos specific common
> compatible. Do you see any issues if we do not have SoC specific
> compatible here.
> 

Gentle ping.

Thanks,
Pankaj Dubey