linux-kernel - Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160311222039.GC3912@kroah.com>
Date:	Fri, 11 Mar 2016 14:20:39 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX

On Fri, Mar 11, 2016 at 10:52:12PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/Kconfig          |   2 +
>  drivers/Makefile         |   1 +
>  drivers/siox/Kconfig     |   2 +
>  drivers/siox/Makefile    |   1 +
>  drivers/siox/siox-core.c | 572 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/siox/siox.h      |  48 ++++
>  include/linux/siox.h     |  53 +++++
>  7 files changed, 679 insertions(+)
>  create mode 100644 drivers/siox/Kconfig
>  create mode 100644 drivers/siox/Makefile
>  create mode 100644 drivers/siox/siox-core.c
>  create mode 100644 drivers/siox/siox.h
>  create mode 100644 include/linux/siox.h

What's the relationship between your "master" and "regular" devices
here?  I think that's getting things confused, you are unregistering
your 'master' yet the children it controls don't go away because you
never unregister them.  You need to fix this heirachy up a bit, and
maybe just drop the 'master' logic?

thanks,

greg k-h