linux-kernel - Re: [PATCH v2] tty: amba-pl011: Use 32-bit accesses for SBSA UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34828481-F042-423A-BCE9-824AAFFA1A13@codeaurora.org>
Date:	Sat, 12 Mar 2016 06:38:44 +0700
From:	Christopher Covington <cov@...eaurora.org>
To:	Peter Hurley <peter@...leysoftware.com>,
	Russell King <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	Timur Tabi <timur@...eaurora.org>, Jon Masters <jcm@...hat.com>,
	Mark Langsdorf <mlangsdo@...hat.com>,
	Andre Przywara <andre.przywara@....com>,
	Dave Martin <dave.martin@....com>,
	Aleksey Makarov <aleksey.makarov@...aro.org>
Subject: Re: [PATCH v2] tty: amba-pl011: Use 32-bit accesses for SBSA UART



On March 11, 2016 10:02:14 PM GMT+07:00, Peter Hurley <peter@...leysoftware.com> wrote:
>Hi Christopher,
>
>On 03/10/2016 10:35 PM, Christopher Covington wrote:
>> Version 2 of the Server Base System Architecture (SBSAv2) describes
>the
>> Generic UART registers as 32 bits wide. At least one implementation,
>found
>> on the Qualcomm Technologies QDF2432, only supports 32 bit accesses.
>> SBSAv3, which describes supported access sizes in greater detail,
>> explicitly requires support for both 16 and 32 bit accesses to all
>> registers (and 8 bit accesses to some but not all). Therefore, for
>broad
>> compatibility, simply use 32 bit accessors for the SBSA UART.
>
>So this eliminates the need to configure SBSA port via ACPI, correct?
>Thus, Aleksey can drop his "serial: pl011: use SPCR to setup 32-bit
>access"?

Yes.

Thanks,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Sent from my Snapdragon powered Android device with K-9 Mail. Please excuse my brevity.