linux-kernel - Re: [PATCH v3 04/14] i2c-octeon: Support I2C_M_RECV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160312154422.GG1661@katana>
Date:	Sat, 12 Mar 2016 16:44:22 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jan Glauber <jglauber@...ium.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v3 04/14] i2c-octeon: Support I2C_M_RECV_LEN

On Mon, Mar 07, 2016 at 04:10:47PM +0100, Jan Glauber wrote:
> From: David Daney <david.daney@...ium.com>
> 
> If I2C_M_RECV_LEN is set consider the length byte.
> 
> Signed-off-by: David Daney <ddaney@...iumnetworks.com>
> Signed-off-by: Jan Glauber <jglauber@...ium.com>

You also might want to set "| I2C_FUNC_SMBUS_READ_BLOCK_DATA |
I2C_FUNC_SMBUS_BLOCK_PROC_CALL" in your functionality?

> +		if (recv_len && i == 0) {
> +			if (data[i] > I2C_SMBUS_BLOCK_MAX + 1) {
> +				dev_err(i2c->dev,
> +					"%s: read len > I2C_SMBUS_BLOCK_MAX %d\n",
> +					__func__, data[i]);
> +				return -EIO;

According to Documentation/i2c/fault-codes this should be -EPROTO.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)