linux-kernel - Re: [PATCH 5/5] hwrng: exynos - Disable runtime PM on driver unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56E3A887.1000807@samsung.com>
Date:	Sat, 12 Mar 2016 14:26:31 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Kukjin Kim <kgene@...nel.org>, linux-crypto@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	k.kozlowski.k@...il.com
Subject: Re: [PATCH 5/5] hwrng: exynos - Disable runtime PM on driver unbind

W dniu 11.03.2016 o 16:49, Krzysztof Kozlowski pisze:
> Driver enabled runtime PM but did not revert this on removal. Re-binding
> of a device triggered warning:
> 	exynos-rng 10830400.rng: Unbalanced pm_runtime_enable!
> 
> Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator")
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  drivers/char/hw_random/exynos-rng.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
> index 68c349bf66a0..cba1ff538c46 100644
> --- a/drivers/char/hw_random/exynos-rng.c
> +++ b/drivers/char/hw_random/exynos-rng.c
> @@ -154,6 +154,13 @@ static int exynos_rng_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> +static int exynos_rng_remove(struct platform_device *pdev)
> +{
> +	pm_runtime_disable(&pdev->dev);
> +

This is not sufficient. pm_runtime_dont_use_autosuspend() is also
necessary here. I will send a v2.

BTW, no problem if it is too late for taking this for v4.6. If this
patchset misses merge window I'll resend it later.

Best regards,
Krzysztof