linux-kernel - Re: [lustre-devel] [PATCH 07/10] staging: lustre: cleanup comment style for lnet selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160312062400.GA13693@kroah.com>
Date:	Fri, 11 Mar 2016 22:24:00 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
Cc:	James Simmons <jsimmons@...radead.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Drokin, Oleg" <oleg.drokin@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH 07/10] staging: lustre: cleanup comment
 style for lnet selftest

On Sat, Mar 12, 2016 at 01:39:01AM +0000, Dilger, Andreas wrote:
> On 2016/03/11, 18:29, "lustre-devel on behalf of James Simmons"
> <lustre-devel-bounces@...ts.lustre.org on behalf of
> jsimmons@...radead.org> wrote:
> 
> >Apply a consistent style for comments in the lnet selftest
> >code.
> >
> >Signed-off-by: James Simmons <jsimmons@...radead.org>
> >---
> > drivers/staging/lustre/lnet/selftest/brw_test.c  |    8 ++--
> > drivers/staging/lustre/lnet/selftest/conctl.c    |   50
> >+++++++++++-----------
> > drivers/staging/lustre/lnet/selftest/conrpc.c    |   23 +++++-----
> > drivers/staging/lustre/lnet/selftest/console.c   |   11 +++--
> > drivers/staging/lustre/lnet/selftest/framework.c |   20 ++++----
> > drivers/staging/lustre/lnet/selftest/ping_test.c |    2 +-
> > drivers/staging/lustre/lnet/selftest/rpc.c       |   46
> >++++++++++----------
> > drivers/staging/lustre/lnet/selftest/rpc.h       |    2 +-
> > drivers/staging/lustre/lnet/selftest/selftest.h  |    3 +-
> > drivers/staging/lustre/lnet/selftest/timer.c     |    6 +-
> > 10 files changed, 87 insertions(+), 84 deletions(-)
> >
> >diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c
> >b/drivers/staging/lustre/lnet/selftest/brw_test.c
> >index eebc924..6ac4d02 100644
> >--- a/drivers/staging/lustre/lnet/selftest/brw_test.c
> >+++ b/drivers/staging/lustre/lnet/selftest/brw_test.c
> >@@ -86,7 +86,7 @@ brw_client_init(sfw_test_instance_t *tsi)
> > 		opc = breq->blk_opc;
> > 		flags = breq->blk_flags;
> > 		npg = breq->blk_npg;
> >-		/*
> >+		/**
> > 		 * NB: this is not going to work for variable page size,
> > 		 * but we have to keep it for compatibility
> > 		 */
> 
> The "/**" comment opener is only for header comment blocks that
> have markup in them.  I don't think that is kernel style for
> normal multi-line comments in the code.

Yes, that is correct.  James, can you fix this up and resend this
series?

thanks,

greg k-h