linux-kernel - Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878u1mlcp5.fsf@ketchup.mtl.sfl>
Date:	Sun, 13 Mar 2016 09:39:02 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Ido Schimmel <idosch@...lanox.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>,
	Kevin Smith <kevin.smith@...csyscorp.com>
Subject: Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Hi Ido,

Ido Schimmel <idosch@...lanox.com> writes:

>>+	case NETDEV_PRECHANGEUPPER:
>
> Why do you need this here? It seems you are always ignoring it in
> dsa_slave_port_upper_event()? Probably better to introduce it when you
> actually need it.
>
> Other than that, it looks good to me.

I've prepare a real v1 without this switch case locally, I'll send it in
a few moment unless there are other comments.

Thanks Ido!
Vivien