linux-kernel - [PATCH] block/xen-blkback: Deinline shrink_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Mar 2016 20:27:23 +0100
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Roger Pau Monné <roger.pau@...rix.com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: [PATCH] block/xen-blkback: Deinline shrink_free_pagepool, save 204 bytes

This function compiles to 201 bytes of machine code. 2 callsites.

This function has a spinlocked code section,
which is significantly more expensive than call/return overhead.

Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC: Roger Pau Monné <roger.pau@...rix.com>
CC: xen-devel@...ts.xenproject.org
CC: linux-kernel@...r.kernel.org
---
 drivers/block/xen-blkback/blkback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index 4809c15..5e3394c 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -155,7 +155,7 @@ static inline void put_free_pages(struct xen_blkif_ring *ring, struct page **pag
 	spin_unlock_irqrestore(&ring->free_pages_lock, flags);
 }
 
-static inline void shrink_free_pagepool(struct xen_blkif_ring *ring, int num)
+static void shrink_free_pagepool(struct xen_blkif_ring *ring, int num)
 {
 	/* Remove requested pages in batches of NUM_BATCH_FREE_PAGES */
 	struct page *page[NUM_BATCH_FREE_PAGES];
-- 
2.5.0