linux-kernel - Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E64B39.5040609@amd.com>
Date:	Mon, 14 Mar 2016 12:25:13 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Paolo Bonzini <pbonzini@...hat.com>, <rkrcmar@...hat.com>,
	<joro@...tes.org>, <bp@...en8.de>, <gleb@...nel.org>,
	<alex.williamson@...hat.com>
CC:	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wei@...hat.com>, <sherry.hurwitz@....com>
Subject: Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC



On 03/07/2016 10:36 PM, Paolo Bonzini wrote:
>
>
> On 04/03/2016 21:46, Suravee Suthikulpanit wrote:
>> +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
>> +{
>> +	struct vcpu_svm *svm = to_svm(vcpu);
>> +
>> +	kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR));
>> +
>> +	if (vcpu->mode == IN_GUEST_MODE) {
>> +		wrmsrl(SVM_AVIC_DOORBELL,
>> +		       __default_cpu_present_to_apicid(vcpu->cpu));
>> +	} else {
>> +		kvm_vcpu_kick(vcpu);
>> +	}
>
> You also need to add
>
> 	kvm_make_request(KVM_REQ_EVENT, vcpu);
>
> before the "if", similar to vmx_deliver_posted_interrupt.
>
> Paolo
>

Actually, I should only need that just before the kvm_cpu_kick(vcpu) 
isn't it. I don't think we need it in the case when sending doorbell.

Thanks,
Suravee