linux-kernel - Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160314005706.GX17997@ZenIV.linux.org.uk>
Date:	Mon, 14 Mar 2016 00:57:06 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	kernel test robot <ying.huang@...ux.intel.com>
Cc:	lkp@...org, LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!

On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups
> commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge lookup_fast()")

Could you check if the diff below fixes it?

diff --git a/fs/namei.c b/fs/namei.c
index 35b10fa..428a34f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1563,6 +1563,7 @@ static int lookup_fast(struct nameidata *nd,
 					dput(dentry);
 					return status;
 				}
+				goto l;
 			}
 		}
 		/*
@@ -1590,6 +1591,7 @@ static int lookup_fast(struct nameidata *nd,
 				return status;
 			}
 		}
+l:
 		if (unlikely(d_is_negative(dentry))) {
 			dput(dentry);
 			return -ENOENT;