linux-kernel - RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169b736d643e43598eceaad3adbdfe6d@SC-EXCH04.marvell.com>
Date:	Mon, 14 Mar 2016 06:32:24 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>
CC:	Cathy Luo <cluo@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Nishant Sarmukadam <nishants@...vell.com>,
	Ganapathi Bhat <gbhat@...vell.com>
Subject: RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for
 Marvell

Hi Marcel,

Do you have any comments for this patch?
Please let us know if you have any more suggestions for the improvements.

> From: Amitkumar Karwar [mailto:akarwar@...vell.com]
> Sent: Thursday, March 03, 2016 5:27 PM
> To: linux-bluetooth@...r.kernel.org
> Cc: Cathy Luo; linux-kernel@...r.kernel.org; Nishant Sarmukadam;
> Ganapathi Bhat; Amitkumar Karwar
> Subject: [PATCH v4] Bluetooth: hci_uart: Support firmware download for
> Marvell
> 
> From: Ganapathi Bhat <gbhat@...vell.com>
> 
> This patch implement firmware download feature for Marvell Bluetooth
> devices. If firmware is already downloaded, it will skip downloading.
> 
> Signed-off-by: Ganapathi Bhat <gbhat@...vell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@...vell.com>
> ---
> v2: Fixed compilation warning reported by kbuild test robot
> v3: Addressed review comments from Marcel Holtmann
>     a) Removed vendor specific code from hci_ldisc.c
>     b) Get rid of static forward declaration
>     c) Removed unnecessary heavy nesting
>     d) Git rid of module parameter and global variables
>     e) Add logic to pick right firmware image
> v4: Addresses review comments from Alan
>     a) Use existing kernel helper APIs instead of writing own.
>     b) Replace mdelay() with msleep()
> ---

Regards,
Amitkumar