linux-kernel - Re: [PATCH 02/22] ncr5380: Remove FLAG_NO_PSEUDO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E66693.1090901@suse.de>
Date:	Mon, 14 Mar 2016 08:21:55 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	Sam Creasey <sammy@...my.net>
Subject: Re: [PATCH 02/22] ncr5380: Remove FLAG_NO_PSEUDO_DMA where possible

On 03/14/2016 05:27 AM, Finn Thain wrote:
> Drivers that define PSEUDO_DMA also define NCR5380_dma_xfer_len.
> The core driver must call NCR5380_dma_xfer_len which means
> FLAG_NO_PSEUDO_DMA can be eradicated from the core driver.
> 
> dmx3191d doesn't define PSEUDO_DMA and has no use for FLAG_NO_PSEUDO_DMA,
> so remove it there also.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c   |    3 +--
>  drivers/scsi/dmx3191d.c  |    2 +-
>  drivers/scsi/g_NCR5380.c |    7 ++++++-
>  drivers/scsi/g_NCR5380.h |    2 +-
>  drivers/scsi/mac_scsi.c  |   15 ++++++++++++++-
>  5 files changed, 23 insertions(+), 6 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)