linux-kernel - Re: [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E667B5.3090708@suse.de>
Date:	Mon, 14 Mar 2016 08:26:45 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	Sam Creasey <sammy@...my.net>
Subject: Re: [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by
 default

On 03/14/2016 05:27 AM, Finn Thain wrote:
> The only chip that needs the workarounds enabled is an early NMOS
> device. That means that the common case is to disable them.
> 
> Unfortunately the sense of the flag is such that it has to be set
> for the common case.
> 
> Rename the flag so that zero can be used to mean "no errata workarounds
> needed". This simplifies the code.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c      |   14 +++++++-------
>  drivers/scsi/NCR5380.h      |    2 +-
>  drivers/scsi/arm/cumana_1.c |    2 +-
>  drivers/scsi/arm/oak.c      |    2 +-
>  drivers/scsi/dtc.c          |    2 +-
>  drivers/scsi/g_NCR5380.c    |    8 +-------
>  drivers/scsi/pas16.c        |    2 +-
>  drivers/scsi/t128.c         |    2 +-
>  8 files changed, 14 insertions(+), 20 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)