linux-kernel - Re: [PATCH v2 2/3] block: convert to device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2016 09:15:00 +0100
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	axboe@...com,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	linux-kernel@...r.kernel.org, hch@....de,
	Keith Busch <keith.busch@...el.com>,
	linux-block@...r.kernel.org,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 2/3] block: convert to device_add_disk()

On Fri, Mar 11, 2016 at 07:47:38AM -0800, Dan Williams wrote:
> For block drivers that specify a parent device, convert them to use
> device_add_disk().
> 
> This conversion was done with the following semantic patch:
> 
>     @@
>     struct gendisk *disk;
>     expression E;
>     @@
> 
>     - disk->driverfs_dev = E;
>     ...
>     - add_disk(disk);
>     + device_add_disk(E, disk);
> 
>     @@
>     struct gendisk *disk;
>     expression E1, E2;
>     @@
> 
>     - disk->driverfs_dev = E1;
>     ...
>     E2 = disk;
>     ...
>     - add_disk(E2);
>     + device_add_disk(E1, E2);
> 
> ...plus some manual fixups for a few missed conversions.
> 
> Cc: Jens Axboe <axboe@...com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Keith Busch <keith.busch@...el.com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: James Bottomley <James.Bottomley@...senpartnership.com>
> Cc: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850