linux-kernel - Re: [PATCH] android: lmk: add swap pte pmd in tasksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E61328.8000101@hisilicon.com>
Date:	Mon, 14 Mar 2016 09:26:00 +0800
From:	Chen Feng <puck.chen@...ilicon.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	yalin wang <yalin.wang2010@...il.com>,
	Lu Bing <albert.lubing@...ilicon.com>,
	<devel@...verdev.osuosl.org>, <dan.zhao@...ilicon.com>,
	<chenxiang9@...wei.com>, <xuyiping@...ilicon.com>,
	<suzhuangluan@...ilicon.com>, <linuxarm@...wei.com>,
	<riandrews@...roid.com>, <alan.wei@...ilicon.com>,
	<linux-kernel@...r.kernel.org>, <arve@...roid.com>,
	<saberlily.xia@...ilicon.com>, <shimingxing@...ilicon.com>,
	<oliver.fu@...ilicon.com>, <liuzixing@...wei.com>,
	<yudongbin@...ilicon.com>, <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH] android: lmk: add swap pte pmd in tasksize

Hi greg,

On 2016/3/12 1:12, Greg KH wrote:
> On Fri, Mar 11, 2016 at 05:05:45PM +0800, Chen Feng wrote:
>>
>>
>> On 2016/3/11 15:30, yalin wang wrote:
>>>
>>>> On Mar 11, 2016, at 15:23, Lu Bing <albert.lubing@...ilicon.com> wrote:
>>>>
>>>> From: l00215322 <albert.lubing@...ilicon.com>
>>>>
>>>> Many android devices have zram,so we should add "MM_SWAPENTS" in tasksize.
>>>> Refer oom_kill.c,we add pte&pmd also.
>>>>
>>>> Reviewed-by: Chen Feng <puck.chen@...ilicon.com>
>>>> Reviewed-by: Fu Jun <oliver.fu@...ilicon.com>
>>>> Reviewed-by: Xu YiPing <xuyiping@...ilicon.com>
>>>> Reviewed-by: Yu DongBin <yudongbin@...ilicon.com>
>>>> Signed-off-by: Lu Bing <albert.lubing@...ilicon.com>
>>>> ---
>>>> drivers/staging/android/lowmemorykiller.c | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
>>>> index 8b5a4a8..0817d3b 100644
>>>> --- a/drivers/staging/android/lowmemorykiller.c
>>>> +++ b/drivers/staging/android/lowmemorykiller.c
>>>> @@ -139,7 +139,9 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
>>>> 			task_unlock(p);
>>>> 			continue;
>>>> 		}
>>>> -		tasksize = get_mm_rss(p->mm);
>>>> +		tasksize = get_mm_rss(p->mm) +
>>>> +			get_mm_counter(p->mm, MM_SWAPENTS) +
>>>> +			atomic_long_read(&p->mm->nr_ptes) + mm_nr_pmds(p->mm);
>>> why not introduce a mm_nr_ptes()  help function here ?
>>> more clear to see .
>>>
>> Since the code is in staging, we can add another patch to do this.
> 
> I do not understand this, please explain.
> 
I mean that we can submit another patch to add mm_nr_ptes() in mm-module and replace the code used nr_ptes
with this interface(mm_nr_ptes()).

This patch is just change the score of task-size in low memory killer.

> thanks,
> 
> greg k-h
> 
> .
>