linux-kernel - Re: [patch] kexec: potetially using uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2016 19:25:25 +0800
From:	Minfei Huang <mnfhuang@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	walter harms <wharms@....de>, xlpang@...hat.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vivek Goyal <vgoyal@...hat.com>,
	Dave Young <dyoung@...hat.com>, Ingo Molnar <mingo@...nel.org>,
	Toshi Kani <toshi.kani@....com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] kexec: potetially using uninitialized variable

On 03/14/16 at 01:58pm, Dan Carpenter wrote:
> On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote:
> > I think we can modify the logic a bit to make code simple. Thus gcc will
> > not complain about any more, and the logic is earier.
> 
> This is a Smatch warning, not a GCC warning.  If you think the new code
> is clearer, that's fine but don't just silence the warning to please
> Smatch.  I'm pretty sure I can silence this warning in Smatch.
> 
> regards,
> dan carpenter
> 

Hi, Dan.

If not a GCC warning, I'm fine to fix it in Smatch, since the code logic
is clear enough.

Thanks
Minfei