linux-kernel - Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160314122104.GF22912@ulmo.nvidia.com>
Date:	Mon, 14 Mar 2016 13:21:05 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Andy Yan <andy.yan@...nel-upstream.org>
CC:	<arnd@...db.de>, <javier@....samsung.com>, <kgene@...nel.org>,
	<k.kozlowski@...sung.com>, <geert+renesas@...der.be>,
	<linux-kernel@...r.kernel.org>, <public_timo.s@...entcreek.de>,
	<linux@....linux.org.uk>, <alexandre.belloni@...e-electrons.com>,
	<sjoerd.simons@...labora.co.uk>, <olof@...om.net>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable
 CONFIG_REGULATOR_PWM=y

On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote:
> Some platform like Rockchip rk3066 use pwm as a regulator to modulate
> cpu voltage, so pwm regulator should be enabled at system boot time if
> the system want to run with high frequency.
> 
> Signed-off-by: Andy Yan <andy.yan@...nel-upstream.org>
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This really belongs in patch 1/2. But then the same comments hold true
and I think you'll need to come up with a proper fix that prevents the
switch to a higher frequency if don't have the necessary regulator, or
make the Kconfig symbol bool if all else fails.

If you make the Kconfig symbol bool I'd expect a really good explanation
in the commit message as to why it can't be fixed properly.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)