linux-kernel - Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11Ea1saj1wfJN5bzU5b_qLnDZAkf5-d2HMNwQXi+diV-A@mail.gmail.com>
Date:	Mon, 14 Mar 2016 15:57:16 +0200
From:	Oded Gabbay <oded.gabbay@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Yair Shachar <yair.shachar@....com>,
	David Airlie <airlied@...ux.ie>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()

On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
>                                 union SQ_CMD_BITS *in_reg_sq_cmd,
>                                 union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
>  {
> -       int status;
> +       int status = 0;
>         union SQ_CMD_BITS reg_sq_cmd;
>         union GRBM_GFX_INDEX_BITS reg_gfx_index;
>         struct HsaDbgWaveMsgAMDGen2 *pMsg;

Thanks,
applied to my fixes tree.

Oded