| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1457965305-3258441-1-git-send-email-arnd@arndb.de> Date: Mon, 14 Mar 2016 15:21:32 +0100 From: Arnd Bergmann <arnd@...db.de> To: Rafał Miłecki <zajec5@...il.com> Cc: Arnd Bergmann <arnd@...db.de>, Ralf Baechle <ralf@...ux-mips.org>, Paul Walmsley <paul@...an.com>, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org Subject: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency The broadcom firmware drvier calls into the ssb SPROM code if that is enabled, but it fails if the SSB code is in a loadable module because the bcm47xx firmware is always built-in: drivers/firmware/built-in.o: In function `bcm47xx_sprom_register_fallbacks': bcm47xx_sprom.c:(.text+0x11c4): undefined reference to `ssb_arch_register_fallback_sprom' This adds a Kconfig dependency to ensure that we cannot turn on the generic sprom support if the ssb sprom is in a module. Signed-off-by: Arnd Bergmann <arnd@...db.de> --- drivers/firmware/broadcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/broadcom/Kconfig b/drivers/firmware/broadcom/Kconfig index 3c7e5b741e37..42f7d9bfb148 100644 --- a/drivers/firmware/broadcom/Kconfig +++ b/drivers/firmware/broadcom/Kconfig @@ -13,6 +13,7 @@ config BCM47XX_NVRAM config BCM47XX_SPROM bool "Broadcom SPROM driver" depends on BCM47XX_NVRAM + depends on SSB=y || SSB=n help Broadcom devices store configuration data in SPROM. Accessing it is specific to the bus host type, e.g. PCI(e) devices have it mapped in -- 2.7.0
Powered by blists - more mailing lists