linux-kernel - Re: [PATCH 5/5] Staging: comedi: Fix type issue in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457966343.11972.94.camel@perches.com>
Date:	Mon, 14 Mar 2016 07:39:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	abbotti@....co.uk
Cc:	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
	geliangtang@....com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: Fix type issue in ni_tio.c

On Mon, 2016-03-14 at 16:36 +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the ni_tio.c file that fixes up a type issues
> found by the checkpatch.pl tool.
> i.e. Prefer kernel type 'u64' over 'uint64_t'
[]
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
[]
> @@ -189,7 +189,7 @@ static void ni_tio_reset_count_and_disarm(struct ni_gpct *counter)
>  static uint64_t ni_tio_clock_period_ps(const struct ni_gpct *counter,
>  				       unsigned generic_clock_source)
>  {
> -	uint64_t clock_period_ps;
> +	u64 clock_period_ps;

Please don't blinkeredly fix checkpatch messages.
Understand the code, not just the checkpatch output.

This function returns a uint64_t, maybe it should be
converted to u64 as well.