linux-kernel - Re: [RFC PATCH] Unexport do_machine_check() and machine_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2016 09:55:17 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] Unexport do_machine_check() and machine_check_poll()

On Mon, Mar 14, 2016 at 05:38:54PM +0100, Borislav Petkov wrote:
> Hey Tony,
> 
> how about the below, untested change?
> 
> Some backporting work to SLE11 got me pondering over why we're exporting
> all those MCA-internal things to modules. Modules don't have any
> business calling those so how about hiding them behind a single point
> mce_call() function which gets a command what to do? This way, we're
> free to change stuff later too, if we decide to do so.

It doesn't seem like a very natural fit ... the three routines
take very different arguments which you bundle into a "void *".

I'm also not sure what we gain. Now we have one, complicated,
exported function that still lets modules do all the things
they could do with the three separate functions.  Is there some
benefit to having fewer exports?

What am I missing?

-Tony