linux-kernel - Re: [PATCH] vmxnet3: fix lock imbalance in vmxnet3_tq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2016 13:11:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	skhare@...are.com, pv-drivers@...are.com, sbhatewara@...are.com,
	gyang@...are.com, nhorman@...driver.com, khoroshilov@...ras.ru,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 14 Mar 2016 15:53:57 +0100

> A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a
> way that left the error handling for oversized headers unlock
> a lock that had not been taken yet. Gcc warns about the incorrect
> use of the 'flags' variable because of that:
> 
> drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_tq_xmit.constprop':
> include/linux/spinlock.h:246:3: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This changes the error handling path to 'goto' the end of the function
> beyond the lock/unlock pair.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: cec05562fb1d ("vmxnet3: avoid calling pskb_may_pull with interrupts disabled")

Applied and queued up for -stable, thanks.