linux-kernel - Re: [RESEND PATCH] pinctrl: rockchip: add support the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2329775.GrlpyGFbsF@diego>
Date:	Mon, 14 Mar 2016 23:36:55 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	linus.walleij@...aro.org, linux-rockchip@...ts.infradead.org,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] pinctrl: rockchip: add support the get_direction

Hi Caesar,

Am Montag, 14. März 2016, 14:01:19 schrieb Caesar Wang:
> This patch adds the get_direction to support the gpio
> interface.
> 
> The gpio direction is not used on rockchip platform when use the gpio
> debugfs.
> 
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in',  since the get_direction didn't supported in rockchip
> pinctrl.
> 
> So, we should add this patch to support it.
> 
> Reported-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-rockchip@...ts.infradead.org
> 
> ---
> 
> Changes in RESEND:
> - Remove the change-id
> 
>  drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index bf032b9..f22a186 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1208,6 +1208,18 @@ static int rockchip_pmx_set(struct pinctrl_dev
> *pctldev, unsigned selector, return 0;
>  }
> 
> +static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned
> offset) +{
> +	struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
> +	int pin;
> +	u32 data;
> +
> +	pin = offset - chip->base;
> +	data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
> +
> +	return !!(data & BIT(pin));

TRM (at least rk3288 and rk3036) says for the SWPORT_DDR register:
(data & BIT(pin)) = 0 = input
(data & BIT(pin)) = 1 = output

struct gpio_chip docs [0] says:
@get_direction: returns 0=out, 1=in,


So shouldn't that be
	return !(data & BIT(pin));
with only one "!" instead of two?
Or as happens sometimes, am I just blind? :-)


Thanks
Heiko

[0] http://lxr.free-electrons.com/source/include/linux/gpio/driver.h#L33