linux-kernel - Re: [PATCH v18 19/22] richacl: Add richacl xattr handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160315071014.GB19747@infradead.org>
Date:	Tue, 15 Mar 2016 00:10:14 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Andreas Gruenbacher <agruenba@...hat.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-nfs@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
	linux-cifs@...r.kernel.org, linux-api@...r.kernel.org,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	linux-kernel@...r.kernel.org, xfs@....sgi.com,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-fsdevel@...r.kernel.org,
	Jeff Layton <jlayton@...chiereds.net>,
	linux-ext4@...r.kernel.org,
	Anna Schumaker <anna.schumaker@...app.com>
Subject: Re: [PATCH v18 19/22] richacl: Add richacl xattr handler

On Fri, Mar 11, 2016 at 09:19:05AM -0500, J. Bruce Fields wrote:
> On Fri, Mar 11, 2016 at 06:17:35AM -0800, Christoph Hellwig wrote:
> > On Mon, Feb 29, 2016 at 09:17:24AM +0100, Andreas Gruenbacher wrote:
> > > Add richacl xattr handler implementing the xattr operations based on the
> > > get_richacl and set_richacl inode operations.
> > 
> > Given all the issues with Posix ACLs and selinux attributes these really
> > should be proper syscalls instead of abusing the xattr interface.
> 
> What are those problems exactly?

That people get confused between the attr used by the xattr syscall
interface and the attr used to store things on disk or the protocol.
This has happened every time we have non-native support, e.g. XFS, NFS,
CIFS, ntfs, etc.  And it's only going to become worse.