linux-kernel - Re: [patch] block-dev: checking for NULL instead of IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160315072603.GC11669@infradead.org>
Date:	Tue, 15 Mar 2016 00:26:03 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>, Shaohua Li <shli@...com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] block-dev: checking for NULL instead of IS_ERR()

On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote:
> This should be an IS_ERR() check.  mount_pseudo() returns error pointers
> and this function should return the error pointer to its caller as well.
> 
> Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Looks fine.  Would be much nicer to simply pass possible flags as an
argument to mount_pseudo to avoid this whole dance..

Reviewed-by: Christoph Hellwig <hch@....de>