linux-kernel - Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160315073455.GH11669@infradead.org>
Date:	Tue, 15 Mar 2016 00:34:55 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	axboe@...nel.dk, torvalds@...ux-foundation.org, hch@...radead.org,
	tytso@....edu, martin.petersen@...cle.com,
	linux-api@...r.kernel.org, david@...morbit.com,
	linux-kernel@...r.kernel.org, shane.seymour@....com,
	bfields@...ldses.org, linux-fsdevel@...r.kernel.org,
	jlayton@...chiereds.net, akpm@...ux-foundation.org
Subject: Re: [PATCH 2/3] block: require write_same and discard requests align
 to logical block size

On Fri, Mar 04, 2016 at 04:56:10PM -0800, Darrick J. Wong wrote:
> Make sure that the offset and length arguments that we're using to
> construct WRITE SAME and DISCARD requests are actually aligned to the
> logical block size.  Failure to do this causes other errors in other
> parts of the block layer or the SCSI layer because disks don't support
> partial logical block writes.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@....de>