linux-kernel - Re: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA23075F4E8FE8F@us01wembx1.internal.synopsys.com>
Date:	Tue, 15 Mar 2016 11:38:34 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Andreas Ziegler <andreas.ziegler@....de>,
	Bjorn Helgaas <helgaas@...nel.org>
CC:	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves

On Tuesday 15 March 2016 04:47 PM, Andreas Ziegler wrote:
> Commit 5f8fc43217a0 ("PCI: Include pci/pcie/Kconfig directly from
> pci/Kconfig") in linux-next changed drivers/pci/Kconfig to include
> drivers/pci/pcie/Kconfig itself, so that architectures do not need
> to source both files themselves. ARC just recently gained PCI support
> through commit 6b3fb77998dd ("ARC: Add PCI support"), but this change
> was based on the old behaviour of the Kconfig files. This makes
> Kconfig now spit out the following warnings:
>
> drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group
> drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group
> drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group
>
> This change updates the Kconfig file for ARC, dropping the now
> unnecessary 'source' statement, which makes the warning disappear.
>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@....de>

Thx for the fix Andreas.

@Bjorn sorry you might to have to pick this one up as well.
If not, that's fine too - I'll queue it up once ARC PCI hits upstream.

Thx,
-Vineet

> ---
>  arch/arc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index 69d05f5..282efec 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -592,7 +592,6 @@ config PCI_SYSCALL
>  	def_bool PCI
>  
>  source "drivers/pci/Kconfig"
> -source "drivers/pci/pcie/Kconfig"
>  
>  endmenu
>