linux-kernel - Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E8055B.6030208@amd.com>
Date:	Tue, 15 Mar 2016 19:51:39 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Paolo Bonzini <pbonzini@...hat.com>, <rkrcmar@...hat.com>,
	<joro@...tes.org>, <bp@...en8.de>, <gleb@...nel.org>,
	<alex.williamson@...hat.com>
CC:	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wei@...hat.com>, <sherry.hurwitz@....com>
Subject: Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers



On 03/14/2016 07:25 PM, Paolo Bonzini wrote:
>
>
> On 14/03/2016 08:41, Suravee Suthikulpanit wrote:
>> Any particular reason why you do not recommend the use of bit field?
>
> 1) The current coding style is generally not using bitfields
>
> 2) Having to review patches that change working code unrelated to AVIC
>
> 3) Most of the fields are not even used when AVIC is enabled, so the
> benefit of the conversion is small.
>
> Paolo
>

Ok I'll remove the bit-field stuff from patch 3 and will get rid off 
patch 4.

Thanks,
Suravee