linux-kernel - Re: [PATCH v5 3/4] i2c: i801: add support of Host Notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2016 23:35:50 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
	Jonathan Corbet <corbet@....net>,
	Corey Minyard <minyard@....org>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Duggan <aduggan@...aptics.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	linux-i2c@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v5 3/4] i2c: i801: add support of Host Notify

Hi Benjamin,

[auto build test WARNING on input/next]
[also build test WARNING on v4.5 next-20160315]
[cannot apply to wsa/i2c/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Tissoires/i2c-smbus-add-support-for-HOST-NOTIFY/20160315-230340
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-x006-201611 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/i2c/busses/i2c-i801.c: In function 'i801_host_notify_isr':
>> drivers/i2c/busses/i2c-i801.c:533:31: warning: passing argument 1 of 'i2c_handle_smbus_host_notify' from incompatible pointer type [-Wincompatible-pointer-types]
     i2c_handle_smbus_host_notify(priv->host_notify, addr, data);
                                  ^
   In file included from drivers/i2c/busses/i2c-i801.c:90:0:
   include/linux/i2c-smbus.h:87:19: note: expected 'struct i2c_adapter *' but argument is of type 'struct smbus_host_notify *'
    static inline int i2c_handle_smbus_host_notify(struct i2c_adapter *adapter,
                      ^

vim +/i2c_handle_smbus_host_notify +533 drivers/i2c/busses/i2c-i801.c

   517			/* Write next byte, except for IRQ after last byte */
   518			outb_p(priv->data[++priv->count], SMBBLKDAT(priv));
   519		}
   520	
   521		/* Clear BYTE_DONE to continue with next byte */
   522		outb_p(SMBHSTSTS_BYTE_DONE, SMBHSTSTS(priv));
   523	}
   524	
   525	static irqreturn_t i801_host_notify_isr(struct i801_priv *priv)
   526	{
   527		unsigned short addr;
   528		unsigned int data;
   529	
   530		addr = inb_p(SMBNTFDADD(priv)) >> 1;
   531		data = inw_p(SMBNTFDDAT(priv));
   532	
 > 533		i2c_handle_smbus_host_notify(priv->host_notify, addr, data);
   534	
   535		/* clear Host Notify bit and return */
   536		outb_p(SMBSLVSTS_HST_NTFY_STS, SMBSLVSTS(priv));
   537		return IRQ_HANDLED;
   538	}
   539	
   540	/*
   541	 * There are three kinds of interrupts:

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22724 bytes)