linux-kernel - Re: Fix suspicious RCU usage in msr tracing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2016 09:39:56 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Dave Jones <davej@...emonkey.org.uk>, x86@...nel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Fix suspicious RCU usage in msr tracing.

> Back in January, Andi suggested swapping the order in which
> we ack the APIC irq, so it too is protected by rcu.
> There was no follow-up, and it seems to work for me.
> 
> Cc: Andi Kleen <ak@...ux.intel.com>

Reviewed-by: Andi Kleen <ak@...ux.intel.com>

-Andi

> Signed-off-by: Dave Jones <davej@...emonkey.org.uk>
> 
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index c80f6b6f3da2..e8c4fba52d3d 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -644,8 +644,8 @@ static inline void entering_irq(void)
>  
>  static inline void entering_ack_irq(void)
>  {
> -	ack_APIC_irq();
>  	entering_irq();
> +	ack_APIC_irq();
>  }
>  
>  static inline void ipi_entering_ack_irq(void)

-- 
ak@...ux.intel.com -- Speaking for myself only