[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160315195443.GD26619@localhost.localdomain>
Date: Tue, 15 Mar 2016 12:54:44 -0700
From: Eduardo Valentin <edubezval@...il.com>
To: Wei Ni <wni@...dia.com>
Cc: rui.zhang@...el.com, thierry.reding@...il.com,
MLongnecker@...dia.com, swarren@...dotorg.org,
mikko.perttunen@...si.fi, linux-tegra@...r.kernel.org,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 05/12] thermal: tegra: add Tegra210 specific SOC_THERM
driver
On Tue, Mar 15, 2016 at 02:59:52PM +0800, Wei Ni wrote:
>
>
> On 2016年03月15日 02:57, Eduardo Valentin wrote:
> > * PGP Signed by an unknown key
> >
> > On Fri, Mar 11, 2016 at 11:10:25AM +0800, Wei Ni wrote:
> >> Add Tegra210 specific SOC_THERM driver.
> >>
> >> Signed-off-by: Wei Ni <wni@...dia.com>
> >> ---
> >> drivers/thermal/tegra/Makefile | 1 +
> >> drivers/thermal/tegra/soctherm-fuse.c | 11 ++
> >> drivers/thermal/tegra/soctherm.c | 6 ++
> >> drivers/thermal/tegra/soctherm.h | 4 +
> >> drivers/thermal/tegra/tegra210-soctherm.c | 173 ++++++++++++++++++++++++++++++
> >
> > No Kconfig change?
>
> Yes, we doesn't need Kconfig change.
>
> As discussed with Thierry in [V1,03/10] thermal: tegra: split tegra_soctherm
> driver, he said:
> "I'd like to do this differently to reduce the number of Kconfig symbols.
> The alternate proposal would be for the TEGRA_SOCTHERM symbol to remain
> as it is and then build in driver support depending on the selected
> ARCH_TEGRA_*_SOC options."
>
> So we only have "config TEGRA_SOCTHERM" in the Kconfig, and in Makefile, we add
> tegra-soctherm-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124-soctherm.o
> tegra-soctherm-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-soctherm.o
makes sense to me.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists