linux-kernel - Re: [PATCH v7] rtc: rewrite DS1302 using SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160315001844.GJ28277@piout.net>
Date:	Tue, 15 Mar 2016 01:18:44 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Sergei Ianovich <ynvich@...il.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Rich Felker <dalias@...c.org>
Cc:	linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>,
	"open list:REAL TIME CLOCK RTC SUBSYSTEM" 
	<rtc-linux@...glegroups.com>, linux-sh@...r.kernel.org
Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI

Hi,

Thank you for your work!

On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote :
> -#ifdef CONFIG_SH_SECUREEDGE5410
> -#include <asm/rtc.h>
> -#include <mach/secureedge5410.h>
> -
> -#define	RTC_RESET	0x1000
> -#define	RTC_IODATA	0x0800
> -#define	RTC_SCLK	0x0400
> -
> -#define set_dp(x)	SECUREEDGE_WRITE_IOPORT(x, 0x1c00)
> -#define get_dp()	SECUREEDGE_READ_IOPORT()
> -#define ds1302_set_tx()
> -#define ds1302_set_rx()
> -

I would like to have a solution for secureedge5410 even if it is
untested. Else, we are breaking an existing platform without any
solution.

I've put the sh maintainers in copy, maybe they have an opinion. Else
I'll let your patch sit in linux-next for the next cycle.

I have further cleanups in that driver but they can probably be done
later.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com