linux-kernel - RE: [WTF] utterly tasteless ABI in hfi1 (around ->write()/->write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <D2F193D21ECD8C45917AD3D5B26513301E28314C@CRSMSX101.amr.corp.intel.com>
Date:	Wed, 16 Mar 2016 22:52:21 +0000
From:	"Dalessandro, Dennis" <dennis.dalessandro@...el.com>
To:	Doug Ledford <dledford@...hat.com>
CC:	Al Viro <viro@...iv.linux.org.uk>,
	infinipath <infinipath@...el.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Weiny, Ira" <ira.weiny@...el.com>,
	"John, Jubin" <jubin.john@...el.com>
Subject: RE: [WTF] utterly tasteless ABI in hfi1 (around
 ->write()/->write_iter())

Just wanted to re-send so it gets picked up by the lists. I was using a different
server than usual and vger did not like it. Hopefully this attempt fares better.
Sorry for the extra noise.

--

 On Wed, Mar 16, 2016 at 11:46:31AM -0400, Doug Ledford wrote:
>Intel: For your own sake's you might want to consider doing something
>simple such as using two files, one for regular commands and one for
>SDMA commands, and modifying both the hfi1 and libpsm2 code bases.  I
>don't care, and I wouldn't force you to do it, but I've made my argument
>to Al and he appears to be running it up the tree, so it might be
>easiest to capitulate.

This should be doable. We could have multiple files and have each implement only
the appropriate handler, write() for control and writev() for data. Another
option we are considering is combine the struct used for regular commands and
the one for SDMA commands into a union in a structure that includes some magic
value that tells us how to interpret the payload. This way whether it's write()
or writev() won't matter we'll know how to handle it. We'll start with fixing
hfi1 first and go from there.

-Denny