linux-kernel - Re: [PATCH] rtc: asm9260: remove incorrect __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E92854.6060705@rempel-privat.de>
Date:	Wed, 16 Mar 2016 10:33:08 +0100
From:	Oleksij Rempel <linux@...pel-privat.de>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Arnd Bergmann <arnd@...db.de>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: asm9260: remove incorrect __init/__exit annotations

Am 16.03.2016 um 10:30 schrieb Alexandre Belloni:
> Hi,
> 
> On 15/03/2016 at 22:44:31 +0100, Arnd Bergmann wrote :
>> The probe and remove callbacks of the platform driver are marked __init
>> and __exit, respectively. However, this is not a correct way to annotate
>> them, as it will result in those sections to be discarded at link time
>> or after boot, while we can actually call them again based on manual
>> unbinding, or deferred probing.
>>
>> Kbuild warns about the problem:
>>
>> WARNING: drivers/rtc/rtc-asm9260.o(.data+0x0): Section mismatch in reference from the variable asm9260_rtc_driver to the function .init.text:asm9260_rtc_probe()
>>
> 
> I'm not sure why this was not caught before. I'm not building all the
> platform but that one should have been easy to find...

Sorry, i'm working on monolit kernel. Haven't seen this warning before :(

>> This removes the annotations, so we no longer branch into missing
>> code and avoid the warning.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: 125e550fd257 ("rtc: add Alphascale asm9260 driver")
>> ---
>>  drivers/rtc/rtc-asm9260.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
>> index 14e08c4c1a01..355fdb97a006 100644
>> --- a/drivers/rtc/rtc-asm9260.c
>> +++ b/drivers/rtc/rtc-asm9260.c
>> @@ -255,7 +255,7 @@ static const struct rtc_class_ops asm9260_rtc_ops = {
>>  	.alarm_irq_enable	= asm9260_alarm_irq_enable,
>>  };
>>  
>> -static int __init asm9260_rtc_probe(struct platform_device *pdev)
>> +static int asm9260_rtc_probe(struct platform_device *pdev)
>>  {
>>  	struct asm9260_rtc_priv *priv;
>>  	struct device *dev = &pdev->dev;
>> @@ -323,7 +323,7 @@ err_return:
>>  	return ret;
>>  }
>>  
>> -static int __exit asm9260_rtc_remove(struct platform_device *pdev)
>> +static int asm9260_rtc_remove(struct platform_device *pdev)
>>  {
>>  	struct asm9260_rtc_priv *priv = platform_get_drvdata(pdev);
>>  
>> -- 
>> 2.7.0
>>
> 


-- 
Regards,
Oleksij



Download attachment "signature.asc" of type "application/pgp-signature" (214 bytes)