linux-kernel - Re: [PATCH v2 all 12/14] memory: omap-gpmc: use of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E9379B.1050103@ti.com>
Date:	Wed, 16 Mar 2016 12:38:19 +0200
From:	Roger Quadros <rogerq@...com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
CC:	<arnd@...db.de>, <shawnguo@...nel.org>, <catalin.marinas@....com>,
	<linux@....linux.org.uk>, <robh+dt@...nel.org>,
	<grant.likely@...aro.org>, <olof@...om.net>,
	<yamada.masahiro@...ionext.com>, <guohanjun@...wei.com>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v2 all 12/14] memory: omap-gpmc: use
 of_platform_default_populate() to populate default bus

On 16/03/16 09:35, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Cc: Roger Quadros <rogerq@...com>
> Cc: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger

> ---
>  drivers/memory/omap-gpmc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 6515dfc..455fc73 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2016,8 +2016,7 @@ no_timings:
>  	/* is child a common bus? */
>  	if (of_match_node(of_default_bus_match_table, child))
>  		/* create children and other common bus children */
> -		if (of_platform_populate(child, of_default_bus_match_table,
> -					 NULL, &pdev->dev))
> +		if (of_platform_default_populate(child, NULL, &pdev->dev))
>  			goto err_child_fail;
>  
>  	return 0;
>