linux-kernel - spurious warning from of_i2c_register_device with fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 12:01:56 +0100
From:	Pavel Machek <pavel@...x.de>
To:	pavel@...x.de
Cc:	wsa@...-dreams.de, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, pantelis.antoniou@...sulko.com,
	grant.likely@...aro.org, robh+dt@...nel.org
Subject: spurious warning from of_i2c_register_device with fixed_regulator?

Hi!

We are getting this in the logs:

i2c i2c-0: of_i2c: invalid reg on /soc/i2c@...04000/vcc3p3-regulator

In the dts we have:

socfpga_cyclone5_sockit.dts:
        regulator_3_3v: vcc3p3-regulator {
	                compatible = "regulator-fixed";
		        regulator-name = "VCC3P3";
		        regulator-min-microvolt = <3300000>;
	                regulator-max-microvolt = <3300000>;
        };

Which seems to trigger

drivers/i2c/i2c-core.c:
      addr_be = of_get_property(node, "reg", &len);
                  if (!addr_be || (len < sizeof(*addr_be))) {
                       dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
...
		      
But we have fixed regulator there, it does not have "reg" property.

Git blame says: a430a3455f2c48995e06b359a82a1109a419e9ef. (And no, I
don't have exactly mainline kernel here, but it should be close enough.)

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html