linux-kernel - Re: [PATCH] mmc: core: remove redundant memset of mmc_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 12:38:10 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: core: remove redundant memset of mmc_decode_cid

On 11 March 2016 at 17:35, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> When initializing sd or sdio card, we get struct mmc_card
> from mmc_alloc_card which allocates it by kzalloc. So we don't
> need another memset while decoding cid.
>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/core/sd.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index bb39a29..b95bd24 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -74,8 +74,6 @@ void mmc_decode_cid(struct mmc_card *card)
>  {
>         u32 *resp = card->raw_cid;
>
> -       memset(&card->cid, 0, sizeof(struct mmc_cid));
> -
>         /*
>          * SD doesn't currently have a version field so we will
>          * have to assume we can parse this.
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html