linux-kernel - Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbcSLV-TKVu+KWt9rz3uEMUfpkBAz0Rd5aBR3LWeSJNQA@mail.gmail.com>
Date:	Wed, 16 Mar 2016 13:03:10 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Phil Reid <preid@...ctromag.com.au>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit

On Fri, Mar 11, 2016 at 5:31 PM, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:

> pca953x_gpio_set_multiple() divides by 4 to convert from longs to bytes,
> which assumes a 32-bit platform, and is not correct on 64-bit platforms.
> Use "sizeof(...)" instead to fix this.
>
> Fixes: b4818afeacbd8182 ("gpio: pca953x: Add set_multiple to allow multiple bits to be set in one write.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Patch applied for fixes. Tagged for stable.
Ack from Phil.

Yours,
Linus Walleij