linux-kernel - Re: [PATCH] x86: dts: ce4100: Fix compatible string for PCF8575 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1458130820.11443.1.camel@codethink.co.uk>
Date:	Wed, 16 Mar 2016 12:20:20 +0000
From:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:	linux-kernel@...r.kernel.org
Cc:	Jiang Liu <jiang.liu@...ux.intel.com>
Subject: Re: [PATCH] x86: dts: ce4100: Fix compatible string for PCF8575 chip

On Wed, 2016-03-16 at 12:15 +0000, Ben Hutchings wrote:
> The binding definition for the PCF857x GPIO expanders doesn't mention
> a "ti,pcf8575" compatible string.  This is apparently because TI is
> only a second source - there is no functional difference between
> PCF8575 chips manufactured by TI and NXP, and the same board might be
> populated with either depending on availability.
> 
> As a practical matter, the gpio-pcf857x driver doesn't match this
> string, so this device tree currently won't work.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Append or replace that with:

Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++--
>  arch/x86/platform/ce4100/falconfalls.dts                     | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
> index 569b16248514..1ff6f8487a2d 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
> @@ -71,7 +71,7 @@ This is an example which is used on FalconFalls:
>  			/* This I2C controller has one gpio controller */
>  			gpio@26 {
>  				#gpio-cells = <2>;
> -				compatible = "ti,pcf8575";
> +				compatible = "nxp,pcf8575";
>  				reg = <0x26>;
>  				gpio-controller;
>  			};
> @@ -85,7 +85,7 @@ This is an example which is used on FalconFalls:
>  
>  			gpio@26 {
>  				#gpio-cells = <2>;
> -				compatible = "ti,pcf8575";
> +				compatible = "nxp,pcf8575";
>  				reg = <0x26>;
>  				gpio-controller;
>  			};
> diff --git a/arch/x86/platform/ce4100/falconfalls.dts b/arch/x86/platform/ce4100/falconfalls.dts
> index ce874f872cc6..4958e0045c34 100644
> --- a/arch/x86/platform/ce4100/falconfalls.dts
> +++ b/arch/x86/platform/ce4100/falconfalls.dts
> @@ -252,7 +252,7 @@
>  
>  						gpio@26 {
>  							#gpio-cells = <2>;
> -							compatible = "ti,pcf8575";
> +							compatible = "nxp,pcf8575";
>  							reg = <0x26>;
>  							gpio-controller;
>  						};
> @@ -266,7 +266,7 @@
>  
>  						gpio@26 {
>  							#gpio-cells = <2>;
> -							compatible = "ti,pcf8575";
> +							compatible = "nxp,pcf8575";
>  							reg = <0x26>;
>  							gpio-controller;
>  						};
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.