linux-kernel - Re: [PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA59LJmHkh74eAQDGVim_Lbm_nOrxJok5Omgcnfu9eSeiQ@mail.gmail.com>
Date:	Wed, 16 Mar 2016 11:55:49 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Johan Hovold <johan@...nel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices

On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer <jwboyer@...oraproject.org> wrote:
> A Fedora user reports that the ftdi_sio driver works properly for the
> ICP DAS I-7561U device.  Further, the user manual for these devices
> instructs users to load the driver and add the ids using the sysfs
> interface.
>
> Add support for these in the driver directly so that the devices work
> out of the box instead of needing manual configuration.
>
> Reported-by: <thesource@...l.ru>
> CC: stable <stable@...r.kernel.org>
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> ---

Anything further I need to do on this patch?

josh

>  drivers/usb/serial/ftdi_sio.c     | 4 ++++
>  drivers/usb/serial/ftdi_sio_ids.h | 8 ++++++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 8c660ae401d8..b61f12160d37 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1004,6 +1004,10 @@ static const struct usb_device_id id_table_combined[] = {
>         { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_DISPLAY_PID) },
>         { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_LITE_PID) },
>         { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ANALOG_PID) },
> +       /* ICP DAS I-756xU devices */
> +       { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> +       { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> +       { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
>         { }                                     /* Terminating entry */
>  };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index a84df2513994..a4ec24ce6a11 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -872,6 +872,14 @@
>  #define NOVITUS_BONO_E_PID             0x6010
>
>  /*
> + * ICPDAS I-756*U devices
> + */
> +#define ICPDAS_VID                             0x1b5c
> +#define ICPDAS_I7560U_PID                      0x0103
> +#define ICPDAS_I7561U_PID                      0x0104
> +#define ICPDAS_I7563U_PID                      0x0105
> +
> +/*
>   * RT Systems programming cables for various ham radios
>   */
>  #define RTSYSTEMS_VID          0x2100  /* Vendor ID */
> --
> 2.5.0
>